Refactor S3 credential handling in aws_utils #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m sources other than environment variables by using the AWS default credential chain. Preserved credential checking before first use to prevent logs from filling up. Also added `aws-credential-types` and `tokio` to dependencies in Cargo.toml and aws_utils/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor S3 credential handling in aws_utils to allow S3 credentials from sources other than environment variables by using the AWS default credential chain.
Preserved credential checking before first use to prevent logs from filling up.
Also added
aws-credential-typesandtokioto dependencies in Cargo.toml and aws_utils/Cargo.tomlThis PR preserves the same S3 client environment variable credential checks while allowing credential sources from IAM roles which is useful for local debugging (
aws sso) and self-hosting on AWS (EC2 IAM role attachment).The AWS S3 Rust SDK uses this default credential chain:
env vars -> shared config/credentials (incl. SSO) -> web identity -> container creds -> EC2 IMDSv2. The new code checks the credential sources and bails with an error if none are found.Closes #185
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.